Release 1.15.1

.github/workflows/ci.yml

@@ -18,6 +18,9 @@ defaults:
     shell: bash
 
 jobs:
+  tidy:
+    uses: taiki-e/workflows/.github/workflows/tidy-no-rust.yml@main
+
   test:
     strategy:
       fail-fast: false
@@ -27,15 +30,15 @@ jobs:
         tool:
           # Note: Specifying the version of valgrind is not supported.
           # cargo-watch is supported by cargo-binstall (through quickinstall)
-          - cargo-hack,cargo-llvm-cov,cargo-minimal-versions,parse-changelog,cargo-udeps,cargo-valgrind,cross,nextest,protoc,shellcheck,shfmt,valgrind,wasm-pack,wasmtime,mdbook,mdbook-linkcheck,cargo-watch
-          - cargo-hack@0.5.22,cargo-llvm-cov@0.5.0,cargo-minimal-versions@0.1.7,parse-changelog@0.5.2,cargo-udeps@0.1.33,cargo-valgrind@2.1.0,cross@0.2.4,nextest@0.9.11,protoc@3.21.8,shellcheck@0.8.0,shfmt@3.5.1,wasm-pack@0.10.3,wasmtime@2.0.0,mdbook@0.4.21,mdbook-linkcheck@0.7.6,cargo-watch@8.1.1
+          - cargo-hack,cargo-llvm-cov,cargo-minimal-versions,parse-changelog,cargo-udeps,cargo-valgrind,cargo-deny,cross,nextest,protoc,shellcheck,shfmt,valgrind,wasm-pack,wasmtime,mdbook,mdbook-linkcheck,cargo-watch
+          - cargo-hack@0.5.24,cargo-llvm-cov@0.5.2,cargo-minimal-versions@0.1.8,parse-changelog@0.5.2,cargo-udeps@0.1.35,cargo-valgrind@2.1.0,cargo-deny@0.13.5,cross@0.2.4,nextest@0.9.11,protoc@3.21.10,shellcheck@0.8.0,shfmt@3.5.1,wasm-pack@0.10.3,wasmtime@3.0.1,mdbook@0.4.22,mdbook-linkcheck@0.7.6,cargo-watch@8.1.1
           # Nextest supports basic version ranges as well
           - nextest@0.9
         include:
           - os: macos-11
-            tool: cargo-hack,cargo-llvm-cov,cargo-minimal-versions,parse-changelog,cargo-udeps,cargo-valgrind,cross,nextest,protoc,shellcheck,shfmt,wasm-pack,wasmtime,mdbook,mdbook-linkcheck,cargo-watch
+            tool: cargo-hack,cargo-llvm-cov,cargo-minimal-versions,parse-changelog,cargo-udeps,cargo-valgrind,cargo-deny,cross,nextest,protoc,shellcheck,shfmt,wasm-pack,wasmtime,mdbook,mdbook-linkcheck,cargo-watch
           - os: windows-2019
-            tool: cargo-hack,cargo-llvm-cov,cargo-minimal-versions,parse-changelog,cargo-udeps,cargo-valgrind,cross,nextest,protoc,shellcheck,shfmt,wasm-pack,wasmtime,mdbook,mdbook-linkcheck,cargo-watch
+            tool: cargo-hack,cargo-llvm-cov,cargo-minimal-versions,parse-changelog,cargo-udeps,cargo-valgrind,cargo-deny,cross,nextest,protoc,shellcheck,shfmt,wasm-pack,wasmtime,mdbook,mdbook-linkcheck,cargo-watch
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v3
@@ -44,21 +47,3 @@ jobs:
       - uses: ./
         with:
           tool: ${{ matrix.tool }}
-
-  tidy:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v3
-        with:
-          persist-credentials: false
-      - uses: taiki-e/install-action@shellcheck
-      - uses: taiki-e/install-action@shfmt
-      - run: npm install prettier
-      - run: shfmt -d $(git ls-files '*.sh')
-        if: always()
-      - run: npx prettier -c $(git ls-files '*.yml')
-        if: always()
-      - run: npx prettier -c $(git ls-files '*.js')
-        if: always()
-      - run: shellcheck $(git ls-files '*.sh')
-        if: always()

CHANGELOG.md

@@ -10,6 +10,41 @@ Note: In this file, do not use the hard wrap in the middle of a sentence for com
 
 ## [Unreleased]
 
+## [1.15.1] - 2022-12-03
+
+- Update `wasmtime@latest` to 3.0.1.
+- Update `protoc@latest` to 3.21.10.
+- Update `cargo-hack@latest` to 0.5.24.
+
+## [1.15.0] - 2022-11-29
+
+- Support `cargo-deny`.
+- Update `mdbook@latest` to 0.4.22.
+
+## [1.14.7] - 2022-11-27
+
+- Update `cargo-llvm-cov@latest` to 0.5.2.
+
+## [1.14.6] - 2022-11-27
+
+- Update `cargo-hack@latest` to 0.5.23.
+- Update `cargo-llvm-cov@latest` to 0.5.1.
+- Update `cargo-minimal-versions@latest` to 0.1.8.
+
+## [1.14.5] - 2022-11-27
+
+- Update `wasmtime@latest` to 3.0.0.
+- Update `cargo-binstall@latest` to 0.17.0.
+
+## [1.14.4] - 2022-11-04
+
+- Update `cargo-udeps@latest` to 0.1.35.
+
+## [1.14.3] - 2022-10-28
+
+- Update `wasmtime@latest` to 2.0.1.
+- Update `protoc@latest` to 3.21.9.
+
 ## [1.14.2] - 2022-10-25
 
 - Update `cargo-hack@latest` to 0.5.22.
@@ -375,7 +410,14 @@ Note: In this file, do not use the hard wrap in the middle of a sentence for com
 
 Initial release
 
-[Unreleased]: https://github.com/taiki-e/install-action/compare/v1.14.2...HEAD
+[Unreleased]: https://github.com/taiki-e/install-action/compare/v1.15.1...HEAD
+[1.15.1]: https://github.com/taiki-e/install-action/compare/v1.15.0...v1.15.1
+[1.15.0]: https://github.com/taiki-e/install-action/compare/v1.14.7...v1.15.0
+[1.14.7]: https://github.com/taiki-e/install-action/compare/v1.14.6...v1.14.7
+[1.14.6]: https://github.com/taiki-e/install-action/compare/v1.14.5...v1.14.6
+[1.14.5]: https://github.com/taiki-e/install-action/compare/v1.14.4...v1.14.5
+[1.14.4]: https://github.com/taiki-e/install-action/compare/v1.14.3...v1.14.4
+[1.14.3]: https://github.com/taiki-e/install-action/compare/v1.14.2...v1.14.3
 [1.14.2]: https://github.com/taiki-e/install-action/compare/v1.14.1...v1.14.2
 [1.14.1]: https://github.com/taiki-e/install-action/compare/v1.14.0...v1.14.1
 [1.14.0]: https://github.com/taiki-e/install-action/compare/v1.13.9...v1.14.0

README.md

@@ -39,7 +39,7 @@ To install a specific version, use `@version` syntax:
 ```yaml
 - uses: taiki-e/install-action@v1
   with:
-    tool: cargo-hack@0.5.22
+    tool: cargo-hack@0.5.24
 ```
 
 To install multiple tools:
@@ -66,21 +66,22 @@ https://spdx.org/licenses
 
 | Name | Where binaries will be installed | Where will it be installed from | Supported platform | License |
 | ---- | -------------------------------- | ------------------------------- | ------------------ | ------- |
+| [**cargo-binstall**][cargo-binstall] | `$CARGO_HOME/bin` | [GitHub Releases](https://github.com/cargo-bins/cargo-binstall/releases) | Linux, macOS, Windows | [GPL-3.0](https://github.com/cargo-bins/cargo-binstall/blob/HEAD/crates/bin/LICENSE) |
+| [**cargo-deny**](https://github.com/EmbarkStudios/cargo-deny) | `$CARGO_HOME/bin` | [GitHub Releases](https://github.com/EmbarkStudios/cargo-deny/releases) | Linux, macOS, Windows | [Apache-2.0](https://github.com/EmbarkStudios/cargo-deny/blob/HEAD/LICENSE-APACHE) OR [MIT](https://github.com/EmbarkStudios/cargo-deny/blob/HEAD/LICENSE-MIT) |
 | [**cargo-hack**](https://github.com/taiki-e/cargo-hack) | `$CARGO_HOME/bin` | [GitHub Releases](https://github.com/taiki-e/cargo-hack/releases) | Linux, macOS, Windows | [Apache-2.0](https://github.com/taiki-e/cargo-hack/blob/HEAD/LICENSE-APACHE) OR [MIT](https://github.com/taiki-e/cargo-hack/blob/HEAD/LICENSE-MIT) |
 | [**cargo-llvm-cov**](https://github.com/taiki-e/cargo-llvm-cov) | `$CARGO_HOME/bin` | [GitHub Releases](https://github.com/taiki-e/cargo-llvm-cov/releases) | Linux, macOS, Windows | [Apache-2.0](https://github.com/taiki-e/cargo-llvm-cov/blob/HEAD/LICENSE-APACHE) OR [MIT](https://github.com/taiki-e/cargo-llvm-cov/blob/HEAD/LICENSE-MIT) |
 | [**cargo-minimal-versions**](https://github.com/taiki-e/cargo-minimal-versions) | `$CARGO_HOME/bin` | [GitHub Releases](https://github.com/taiki-e/cargo-minimal-versions/releases) | Linux, macOS, Windows | [Apache-2.0](https://github.com/taiki-e/cargo-minimal-versions/blob/HEAD/LICENSE-APACHE) OR [MIT](https://github.com/taiki-e/cargo-minimal-versions/blob/HEAD/LICENSE-MIT) |
 | [**cargo-udeps**](https://github.com/est31/cargo-udeps) | `$CARGO_HOME/bin` | [GitHub Release](https://github.com/est31/cargo-udeps/releases) | Linux, macOS, Windows | [Apache-2.0 OR MIT](https://github.com/est31/cargo-udeps/blob/master/LICENSE) |
-| [**parse-changelog**](https://github.com/taiki-e/parse-changelog) | `$CARGO_HOME/bin` | [GitHub Releases](https://github.com/taiki-e/parse-changelog/releases) | Linux, macOS, Windows | [Apache-2.0](https://github.com/taiki-e/parse-changelog/blob/HEAD/LICENSE-APACHE) OR [MIT](https://github.com/taiki-e/parse-changelog/blob/HEAD/LICENSE-MIT) |
-| [**cargo-binstall**][cargo-binstall] | `$CARGO_HOME/bin` | [GitHub Releases](https://github.com/cargo-bins/cargo-binstall/releases) | Linux, macOS, Windows | [GPL-3.0](https://github.com/cargo-bins/cargo-binstall/blob/HEAD/crates/bin/LICENSE) |
+| [**cargo-valgrind**](https://github.com/jfrimmel/cargo-valgrind) | `$CARGO_HOME/bin` | [GitHub Release](https://github.com/jfrimmel/cargo-valgrind/releases) | Linux, macOS, Windows | [MIT](https://github.com/jfrimmel/cargo-valgrind/blob/master/LICENSE-MIT) or [Apache-2.0](https://github.com/jfrimmel/cargo-valgrind/blob/master/LICENSE-APACHE) |
 | [**cross**](https://github.com/cross-rs/cross) | `$CARGO_HOME/bin` | [GitHub Releases](https://github.com/cross-rs/cross/releases) | Linux, macOS, Windows | [Apache-2.0](https://github.com/cross-rs/cross/blob/HEAD/LICENSE-APACHE) OR [MIT](https://github.com/cross-rs/cross/blob/HEAD/LICENSE-MIT) |
-| [**mdbook**](https://github.com/rust-lang/mdBook) | `$CARGO_HOME/bin` | [GitHub Releases](https://github.com/rust-lang/mdBook/releases) | Linux, macOS, Windows | [MPL-2.0](https://github.com/rust-lang/mdBook/blob/HEAD/LICENSE) |
 | [**mdbook-linkcheck**](https://github.com/Michael-F-Bryan/mdbook-linkcheck) | `$CARGO_HOME/bin` | [GitHub Releases](https://github.com/Michael-F-Bryan/mdbook-linkcheck/releases) | Linux, macOS, Windows | [MIT](https://github.com/Michael-F-Bryan/mdbook-linkcheck/blob/HEAD/LICENSE) |
+| [**mdbook**](https://github.com/rust-lang/mdBook) | `$CARGO_HOME/bin` | [GitHub Releases](https://github.com/rust-lang/mdBook/releases) | Linux, macOS, Windows | [MPL-2.0](https://github.com/rust-lang/mdBook/blob/HEAD/LICENSE) |
 | [**nextest**](https://github.com/nextest-rs/nextest) (alias: `cargo-nextest`) | `$CARGO_HOME/bin` | [GitHub Releases](https://github.com/nextest-rs/nextest/releases) | Linux, macOS, Windows | [Apache-2.0](https://github.com/nextest-rs/nextest/blob/HEAD/LICENSE-APACHE) OR [MIT](https://github.com/nextest-rs/nextest/blob/HEAD/LICENSE-MIT) |
+| [**parse-changelog**](https://github.com/taiki-e/parse-changelog) | `$CARGO_HOME/bin` | [GitHub Releases](https://github.com/taiki-e/parse-changelog/releases) | Linux, macOS, Windows | [Apache-2.0](https://github.com/taiki-e/parse-changelog/blob/HEAD/LICENSE-APACHE) OR [MIT](https://github.com/taiki-e/parse-changelog/blob/HEAD/LICENSE-MIT) |
 | [**protoc**](https://github.com/protocolbuffers/protobuf) | `$HOME/.install-action/bin` | [GitHub Releases](https://github.com/protocolbuffers/protobuf/releases) | Linux, macOS, Windows | [BSD-3-Clause](https://github.com/protocolbuffers/protobuf/blob/HEAD/LICENSE) |
 | [**shellcheck**](https://www.shellcheck.net) | `/usr/local/bin` | [GitHub Releases](https://github.com/koalaman/shellcheck/releases) | Linux, macOS, Windows | [GPL-3.0-or-later](https://github.com/koalaman/shellcheck/blob/HEAD/LICENSE) |
 | [**shfmt**](https://github.com/mvdan/sh) | `/usr/local/bin` | [GitHub Releases](https://github.com/mvdan/sh/releases) | Linux, macOS, Windows | [BSD-3-Clause](https://github.com/mvdan/sh/blob/HEAD/LICENSE) |
 | [**valgrind**](https://valgrind.org) | `/snap/bin` | [snap](https://snapcraft.io/install/valgrind/ubuntu) | Linux | [GPL-2.0-or-later](https://valgrind.org/docs/manual/license.gpl.html) |
-| [**cargo-valgrind**](https://github.com/jfrimmel/cargo-valgrind) | `$CARGO_HOME/bin` | [GitHub Release](https://github.com/jfrimmel/cargo-valgrind/releases) | Linux, macOS, Windows | [MIT](https://github.com/jfrimmel/cargo-valgrind/blob/master/LICENSE-MIT) or [Apache-2.0](https://github.com/jfrimmel/cargo-valgrind/blob/master/LICENSE-APACHE) |
 | [**wasm-pack**](https://github.com/rustwasm/wasm-pack) | `$CARGO_HOME/bin` | [GitHub Releases](https://github.com/rustwasm/wasm-pack/releases) | Linux, macOS, Windows | [Apache-2.0](https://github.com/rustwasm/wasm-pack/blob/HEAD/LICENSE-APACHE) OR [MIT](https://github.com/rustwasm/wasm-pack/blob/HEAD/LICENSE-MIT) |
 | [**wasmtime**](https://github.com/bytecodealliance/wasmtime) | `$CARGO_HOME/bin` | [GitHub Releases](https://github.com/bytecodealliance/wasmtime/releases) | Linux, macOS, Windows | [Apache-2.0 WITH LLVM-exception](https://github.com/bytecodealliance/wasmtime/blob/HEAD/LICENSE) |
 

main.sh

@@ -80,7 +80,7 @@ host_triple() {
 }
 install_cargo_binstall() {
     # https://github.com/cargo-bins/cargo-binstall/releases
-    binstall_version="0.16.0"
+    binstall_version="0.17.0"
     install_binstall='1'
     if [[ -f "${cargo_bin}/cargo-binstall${exe}" ]]; then
         if [[ "$(cargo binstall -V)" == "cargo-binstall ${binstall_version}" ]]; then
@@ -177,11 +177,11 @@ for tool in "${tools[@]}"; do
         cargo-hack | cargo-llvm-cov | cargo-minimal-versions | parse-changelog)
             case "${tool}" in
                 # https://github.com/taiki-e/cargo-hack/releases
-                cargo-hack) latest_version="0.5.22" ;;
+                cargo-hack) latest_version="0.5.24" ;;
                 # https://github.com/taiki-e/cargo-llvm-cov/releases
-                cargo-llvm-cov) latest_version="0.5.0" ;;
+                cargo-llvm-cov) latest_version="0.5.2" ;;
                 # https://github.com/taiki-e/cargo-minimal-versions/releases
-                cargo-minimal-versions) latest_version="0.1.7" ;;
+                cargo-minimal-versions) latest_version="0.1.8" ;;
                 # https://github.com/taiki-e/parse-changelog/releases
                 parse-changelog) latest_version="0.5.2" ;;
                 *) exit 1 ;;
@@ -201,7 +201,7 @@ for tool in "${tools[@]}"; do
             ;;
         cargo-udeps)
             # https://github.com/est31/cargo-udeps/releases
-            latest_version="0.1.33"
+            latest_version="0.1.35"
             repo="est31/${tool}"
             case "${version}" in
                 latest) version="${latest_version}" ;;
@@ -250,6 +250,22 @@ for tool in "${tools[@]}"; do
             esac
             download "${url}" "${cargo_bin}" "${tool}${exe}"
             ;;
+        cargo-deny)
+            # https://github.com/EmbarkStudios/cargo-deny/releases
+            latest_version="0.13.5"
+            repo="EmbarkStudios/${tool}"
+            case "${version}" in
+                latest) version="${latest_version}" ;;
+            esac
+            case "${OSTYPE}" in
+                linux*) target="x86_64-unknown-linux-musl" ;;
+                darwin*) target="x86_64-apple-darwin" ;;
+                cygwin* | msys*) target="x86_64-pc-windows-msvc" ;;
+                *) bail "unsupported OSTYPE '${OSTYPE}' for ${tool}" ;;
+            esac
+            url="https://github.com/${repo}/releases/download/${version}/${tool}-${version}-${target}.tar.gz"
+            download "${url}" "${cargo_bin}" "${tool}-${version}-${target}/${tool}${exe}"
+            ;;
         cross)
             # https://github.com/cross-rs/cross/releases
             latest_version="0.2.4"
@@ -290,7 +306,7 @@ for tool in "${tools[@]}"; do
             ;;
         protoc)
             # https://github.com/protocolbuffers/protobuf/releases
-            latest_version="3.21.8"
+            latest_version="3.21.10"
             repo="protocolbuffers/protobuf"
             case "${version}" in
                 latest) version="${latest_version}" ;;
@@ -420,7 +436,7 @@ for tool in "${tools[@]}"; do
             ;;
         wasmtime)
             # https://github.com/bytecodealliance/wasmtime/releases
-            latest_version="2.0.0"
+            latest_version="3.0.1"
             repo="bytecodealliance/${tool}"
             case "${version}" in
                 latest) version="${latest_version}" ;;
@@ -445,7 +461,7 @@ for tool in "${tools[@]}"; do
             ;;
         mdbook)
             # https://github.com/rust-lang/mdBook/releases
-            latest_version="0.4.21"
+            latest_version="0.4.22"
             repo="rust-lang/mdBook"
             case "${version}" in
                 latest) version="${latest_version}" ;;

tools/publish.sh

@@ -8,8 +8,8 @@ cd "$(dirname "$0")"/..
 # USAGE:
 #    ./tools/publish.sh <VERSION>
 #
-# Note:
-# - This script requires parse-changelog <https://github.com/taiki-e/parse-changelog>
+# Note: This script requires the following tools:
+# - parse-changelog <https://github.com/taiki-e/parse-changelog>
 
 bail() {
     echo >&2 "error: $*"
@@ -77,19 +77,20 @@ if [[ -n "${tags}" ]]; then
 fi
 
 tools=(
+    cargo-binstall
+    cargo-deny
     cargo-hack
     cargo-llvm-cov
     cargo-minimal-versions
+    cargo-nextest
     cargo-udeps
     cargo-valgrind
-    parse-changelog
-    cargo-binstall
     cross
     mdbook
     mdbook-linkcheck
-    protoc
     nextest
-    cargo-nextest
+    parse-changelog
+    protoc
     shellcheck
     shfmt
     valgrind

tools/tidy.sh

@@ -9,8 +9,14 @@ cd "$(dirname "$0")"/..
 #
 # Note: This script requires the following tools:
 # - shfmt
-# - prettier
 # - shellcheck
+# - npm (if any of YAML/JavaScript/JSON exists)
+# - jq and yq (if this repository uses bors)
+# - clang-format (if any of C/C++ exists)
+#
+# This script is shared with other repositories, so there may also be
+# checks for files not included in this repository, but they will be
+# skipped if the corresponding files do not exist.
 
 x() {
     local cmd="$1"
@@ -24,14 +30,33 @@ x() {
         "${cmd}" "$@"
     fi
 }
+check_diff() {
+    if [[ -n "${CI:-}" ]]; then
+        if ! git --no-pager diff --exit-code "$@"; then
+            should_fail=1
+        fi
+    else
+        if ! git --no-pager diff --exit-code "$@" &>/dev/null; then
+            should_fail=1
+        fi
+    fi
+}
 warn() {
-    echo >&2 "warning: $*"
+    if [[ -n "${GITHUB_ACTIONS:-}" ]]; then
+        echo "::warning::$*"
+    else
+        echo >&2 "warning: $*"
+    fi
+    should_fail=1
 }
 
 if [[ "${1:-}" == "-v" ]]; then
     shift
     verbose=1
 fi
+if [[ -n "${CI:-}" ]]; then
+    verbose=1
+fi
 if [[ $# -gt 0 ]]; then
     cat <<EOF
 USAGE:
@@ -40,24 +65,74 @@ EOF
     exit 1
 fi
 
-prettier=prettier
-if type -P npm &>/dev/null && type -P "$(npm bin)/prettier" &>/dev/null; then
-    prettier="$(npm bin)/prettier"
+# C/C++ (if exists)
+if [[ -n "$(git ls-files '*.c')$(git ls-files '*.cpp')" ]]; then
+    if [[ ! -e .clang-format ]]; then
+        warn "could not fount .clang-format in the repository root"
+    fi
+    if type -P clang-format &>/dev/null; then
+        x clang-format -i $(git ls-files '*.c') $(git ls-files '*.cpp')
+        check_diff $(git ls-files '*.c') $(git ls-files '*.cpp')
+    else
+        warn "'clang-format' is not installed"
+    fi
 fi
 
+# YAML/JavaScript/JSON (if exists)
+if [[ -n "$(git ls-files '*.yml')$(git ls-files '*.js')$(git ls-files '*.json')" ]]; then
+    if type -P npm &>/dev/null; then
+        if [[ ! -e node_modules/.bin/prettier ]]; then
+            x npm install prettier &>/dev/null
+        fi
+        x npx prettier -l -w $(git ls-files '*.yml') $(git ls-files '*.js') $(git ls-files '*.json')
+        check_diff $(git ls-files '*.yml') $(git ls-files '*.js') $(git ls-files '*.json')
+    else
+        warn "'npm' is not installed"
+    fi
+    if [[ -e .github/workflows/ci.yml ]] && grep -q '# tidy:needs' .github/workflows/ci.yml; then
+        if type -P jq &>/dev/null && type -P yq &>/dev/null; then
+            # shellcheck disable=SC2207
+            jobs_actual=($(yq '.jobs' .github/workflows/ci.yml | jq -r 'keys_unsorted[]'))
+            unset 'jobs_actual[${#jobs_actual[@]}-1]'
+            # shellcheck disable=SC2207
+            jobs_expected=($(yq -r '.jobs."ci-success".needs[]' .github/workflows/ci.yml))
+            if [[ "${jobs_actual[*]}" != "${jobs_expected[*]+"${jobs_expected[*]}"}" ]]; then
+                printf -v jobs '%s, ' "${jobs_actual[@]}"
+                sed -i "s/needs: \[.*\] # tidy:needs/needs: [${jobs%, }] # tidy:needs/" .github/workflows/ci.yml
+                check_diff .github/workflows/ci.yml
+                warn "please update 'needs' section in 'ci-success' job"
+            fi
+        else
+            warn "'jq' or 'yq' is not installed"
+        fi
+    fi
+fi
+if [[ -n "$(git ls-files '*.yaml')" ]]; then
+    warn "please use '.yml' instead of '.yaml' for consistency"
+    git ls-files '*.yaml'
+fi
+
+# Shell scripts
 if type -P shfmt &>/dev/null; then
     x shfmt -l -w $(git ls-files '*.sh')
+    check_diff $(git ls-files '*.sh')
 else
     warn "'shfmt' is not installed"
 fi
-if type -P "${prettier}" &>/dev/null; then
-    x "${prettier}" -l -w $(git ls-files '*.yml')
-    x "${prettier}" -l -w $(git ls-files '*.js')
-else
-    warn "'prettier' is not installed"
-fi
 if type -P shellcheck &>/dev/null; then
-    x shellcheck $(git ls-files '*.sh')
+    if ! x shellcheck $(git ls-files '*.sh'); then
+        should_fail=1
+    fi
+    if [[ -n "$(git ls-files '*Dockerfile')" ]]; then
+        # SC2154 doesn't seem to work on dockerfile.
+        if ! x shellcheck -e SC2148,SC2154,SC2250 $(git ls-files '*Dockerfile'); then
+            should_fail=1
+        fi
+    fi
 else
     warn "'shellcheck' is not installed"
 fi
+
+if [[ -n "${should_fail:-}" ]]; then
+    exit 1
+fi